Re: [PATCH 02/16] Add zeroRecPtr as a shortcut for initializing a local variable to {0, 0} - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH 02/16] Add zeroRecPtr as a shortcut for initializing a local variable to {0, 0}
Date
Msg-id 201206141557.53982.andres@2ndquadrant.com
Whole thread Raw
In response to Re: [PATCH 02/16] Add zeroRecPtr as a shortcut for initializing a local variable to {0, 0}  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [PATCH 02/16] Add zeroRecPtr as a shortcut for initializing a local variable to {0, 0}  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thursday, June 14, 2012 03:50:28 PM Robert Haas wrote:
> On Wed, Jun 13, 2012 at 7:28 AM, Andres Freund <andres@2ndquadrant.com> 
wrote:
> > This is locally defined in lots of places and would get introduced
> > frequently in the next commits. It is expected that this can be defined
> > in a header-only manner as soon as the XLogInsert scalability groundwork
> > from Heikki gets in.
> 
> This appears to be redundant with the existing InvalidXLogRecPtr,
> defined in access/transam.h.
Oh. I didn't find that one. Judging from all the code defining local variants 
of it I am not alone in that... Why is it in transam.h and not xlogdefs.h?

Obviously that patch is void then. Doesn't warrant rebasing the other patches 
yet though...

Thanks!

Andres
-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink
Next
From: Robert Haas
Date:
Subject: Re: creating objects in pg_catalog