Re: psql omits row count under "\x auto" - Mailing list pgsql-hackers

From Noah Misch
Subject Re: psql omits row count under "\x auto"
Date
Msg-id 20120427190541.GA25553@tornado.leadboat.com
Whole thread Raw
In response to Re: psql omits row count under "\x auto"  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: psql omits row count under "\x auto"  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Thu, Apr 26, 2012 at 09:25:25PM +0300, Peter Eisentraut wrote:
> On m??n, 2012-04-23 at 12:30 -0400, Noah Misch wrote:
> > I've been enjoying "\x auto" in .psqlrc, but I noticed the row count footer
> > missing when it chooses ordinary output:
>
> > Looks like the logic in printQuery() needs further treatment.
>
> Hmm, this looks a bit tricky, because at the time we add the footer we
> don't yet know which output format will be used.  I don't have a good
> idea how to fix that at the moment.

I fiddled with this and settled on moving the default_footer boolean setting
and the interpretation thereof down from the printQuery() level to the
printTable() level.  That permits delaying the decision until we determine
whether the final output format is indeed vertical.

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: smart shutdown at end of transaction (was: Default mode for shutdown)
Next
From: Heikki Linnakangas
Date:
Subject: Re: smart shutdown at end of transaction (was: Default mode for shutdown)