Re: Command Triggers, patch v11 - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Command Triggers, patch v11
Date
Msg-id 201203041650.39826.andres@anarazel.de
Whole thread Raw
In response to Re: Command Triggers, patch v11  (Thom Brown <thom@linux.com>)
Responses Re: Command Triggers, patch v11  (Thom Brown <thom@linux.com>)
Re: Command Triggers, patch v11  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On Saturday, March 03, 2012 01:08:33 AM Thom Brown wrote:
> On 2 March 2012 23:33, Thom Brown <thom@linux.com> wrote:
> > On 2 March 2012 22:32, Dimitri Fontaine <dimitri@2ndquadrant.fr> wrote:
> >>>> test=# CREATE TABLE badname (id int, a int, b text);
> >>>> ERROR:  invalid relation name: badname
> >>>> test=# CREATE TABLE badname AS SELECT 1::int id, 1::int a, ''::text b;
> >>>> SELECT 1
> >>>> 
> >>>> This doesn't even get picked up by ANY COMMAND.
> >> 
> >> I think Andres should add an entry for his patch on the commitfest.  Is
> >> it ok?
> > 
> > I'll try Andres' patch this weekend while I test yours.
> 
> Actually no matter which patch I apply first, they cause the other to
> fail to apply.
Ok, I rebased my patch ontop of dim's current HEAD. There was only one trivial 
conflict in tablecmds.h. I had written the patch independently of the command 
triggers stuff because I though, and still do, that would make applying it 
easier.

Attached are two versions of the patch, one based on command triggers and one 
without. Both pass regression tests for me.

Andres

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Patch review for logging hooks (CF 2012-01)
Next
From: Michael Meskes
Date:
Subject: Re: ECPG FETCH readahead