Re: pg_upgrade --logfile option documentation - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_upgrade --logfile option documentation
Date
Msg-id 20120228191610.GB14565@momjian.us
Whole thread Raw
In response to Re: pg_upgrade --logfile option documentation  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
On Tue, Feb 28, 2012 at 03:48:03PM -0300, Alvaro Herrera wrote:
> 
> Excerpts from Robert Haas's message of mar feb 28 15:24:45 -0300 2012:
> 
> > I think you should rename the old control file just before the step
> > that says "linking user relation files".  That's the point after which
> > it becomes unsafe to start the old cluster, right?
> 
> Also, if it's not using link mode, what is the point in doing the rename
> in the first place?  I was using copy mode when I did my tests and yet
> it got renamed (unless link mode is now the default, which I doubt?)

You are right that we lock unconditionally.  We can certainly only lock
in link mode.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pg_upgrade --logfile option documentation
Next
From: Simon Riggs
Date:
Subject: Re: CLOG contention, part 2