Re: ecpglib use PQconnectdbParams - Mailing list pgsql-hackers

From Marko Kreen
Subject Re: ecpglib use PQconnectdbParams
Date
Msg-id 20120206165044.GA16393@gmail.com
Whole thread Raw
In response to Re: ecpglib use PQconnectdbParams  (Christian Ullrich <chris@chrullrich.net>)
List pgsql-hackers
On Fri, Feb 03, 2012 at 01:15:30PM +0100, Christian Ullrich wrote:
> * Peter Eisentraut wrote:
> >I noticed ecpglib still uses PQconnectdb() with a craftily assembled
> >connection string.  Here is a patch to use PQconnectdbParams() instead.
> 
> +    const char *conn_keywords[6];
> +    const char *conn_values[6];
> 
> Shouldn't these be [7]? You can have up to 6 items, plus the terminator.

This bug is now in GIT.

-- 
marko



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: freezing multixacts
Next
From: Robert Haas
Date:
Subject: Re: about type cast