Re: pg_upgrade with plpython is broken - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_upgrade with plpython is broken
Date
Msg-id 20120125034735.GB20362@momjian.us
Whole thread Raw
In response to Re: pg_upgrade with plpython is broken  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Fri, Jan 20, 2012 at 07:01:46AM +0200, Peter Eisentraut wrote:
> On tor, 2012-01-19 at 17:04 -0500, Bruce Momjian wrote:
> > For that reason, I wonder if I should just hard-code the plpython
> > rename into the pg_upgrade test in check_loadable_libraries().
>
> Yes, I haven't come up with a better solution either.
>
> If this becomes a general problem, we might need to add a command line
> option to ignore certain names or something.  But not yet.

Well, the problem is a little more complex than reported.  It turns out
in PG 9.0 we kept the plpython.so file and symlinked plpython2.so to it.
In PG 9.1, we removed plpython.so, and only have plpython2.so, so the
problem is with PG >= 9.1, and does not affect 9.0, which explains why
we didn't get any 9.0 reports of a problem.

I have applied the attached patch to PG head and 9.1 to fix the library
checking problem.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Fix for pg_upgrade tablespace function usage
Next
From: Simon Riggs
Date:
Subject: Re: Group commit, revised