Re: pgsql: Fix Perl copyright script to skip .git subdirectory; running it - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Fix Perl copyright script to skip .git subdirectory; running it
Date
Msg-id 20120102002440.GA24093@momjian.us
Whole thread Raw
In response to Re: pgsql: Fix Perl copyright script to skip .git subdirectory; running it  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Fix Perl copyright script to skip .git subdirectory; running it  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: pgsql: Fix Perl copyright script to skip .git subdirectory; running it  (Bruce Momjian <bruce@momjian.us>)
List pgsql-committers
On Sun, Jan 01, 2012 at 07:05:24PM -0500, Andrew Dunstan wrote:
>
>
> On 01/01/2012 05:59 PM, Bruce Momjian wrote:
> >Fix Perl copyright script to skip .git subdirectory;  running it on
> >those files corrupts the index.
>
>
> This patch looks a bit dubious. Instead of:
>
>    if ($File::Find::name =~ m{^\./\.git$})
>
> I'd use:
>
>    if ($_ eq '.git')

The question was whether we wanted to skip non-top-of-tree .git
directories.   I wasn't sure we wanted to do that.  Do we?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Fix Perl copyright script to skip .git subdirectory; running it
Next
From: Bruce Momjian
Date:
Subject: pgsql: Skip 'ico' and 'bin' extensions in copyright changes.