Re: [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch() - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch()
Date
Msg-id 201111282147.pASLlrB21110@momjian.us
Whole thread Raw
In response to Re: [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On Friday, November 18, 2011 10:14:22 PM Tom Lane wrote:
> >> Andres Freund <andres@anarazel.de> writes:
> >>> Replacing the if chain with if; else if; ... resulted in a small
> >>> speedup. Replacing it with a switch() in a bigger one.
> 
> >> Cool, but this patch is impossible to validate by eye.  Could you
> >> resubmit a version that doesn't reindent unchanged code?  Leave it
> >> for pgindent to clean that up later.
> 
> > Sure. It was just to confusing reading the code without reindenting.
> > Btw, I found git diff/show/blame -w very useful to view reindent code.
> 
> Applied, thanks.  Bruce, would you mind running pgindent on
> just src/backend/optimizer/util/clauses.c ?  That seems safer than
> reindenting manually.

Done.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + It's impossible for everything to be true. +


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: strange nbtree corruption report
Next
From: Nathan Wagner
Date:
Subject: Re: psql line number reporting from stdin