On Fri, Aug 19, 2011 at 07:37:29PM -0400, Andrew Dunstan wrote:
>
>
> On 08/19/2011 07:31 PM, Bruce Momjian wrote:
> >Kris Jurka wrote:
> >>Did you also try the "use Tie::File" addition in my fix because your
> >>current coding doesn't work at all. The tie operation is key to actually
> >>writing out the modified copyright notice. Your version just updates the
> >>copyright year in memory, but never gets it back to the file.
> >Ah, that did fix it; thanks. I am attached the updated committed
> >copyright.pl. I also skipped symlinks.
> >
>
> It probably doesn't matter that much in this context, but I should
> point out that Tie::File is not universally available. Some years
> ago I had to revert its use in the buildfarm code for that reason.
> In general we should try to avoid adding extra dependencies wherever
> possible.
Tie::File ships as part of core Perl for all non-EOL versions, so I
really can't consider this as a problem.
Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
