Re: Patch by request at pgcon - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: Patch by request at pgcon
Date
Msg-id 20110519175359.GN4548@tamriel.snowman.net
Whole thread Raw
In response to Patch by request at pgcon  (Greg Stark <stark@mit.edu>)
Responses Re: Patch by request at pgcon  (Greg Stark <stark@mit.edu>)
List pgsql-hackers
* Greg Stark (stark@mit.edu) wrote:
> Adding such a feature would be pretty trivial, attached is a patch.

Quick code-only review: sortedAttrs is a horrible var name for what it
is.  More like 'sortbyName' would make more sense, at least to me.
Also, no regression test..? :)  The interface looks alright to me,
though I wonder for a moment if this might be a \set option.  Are there
other things which could be sorted differently based on such an
option..?  If not, then perhaps another char for \dt is right.
Thanks,
    Stephen

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: LOCK DATABASE
Next
From: Alvaro Herrera
Date:
Subject: Re: Patch by request at pgcon