Re: Typed table DDL loose ends - Mailing list pgsql-hackers

From Noah Misch
Subject Re: Typed table DDL loose ends
Date
Msg-id 20110420145334.GB31420@tornado.leadboat.com
Whole thread Raw
In response to Re: Typed table DDL loose ends  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: Typed table DDL loose ends
List pgsql-hackers
On Mon, Apr 18, 2011 at 10:44:53PM +0300, Peter Eisentraut wrote:
> On Sat, 2011-04-09 at 21:57 -0400, Noah Misch wrote:
> > * Inheriting from a typed table blocks further type DDL
> >   CREATE TYPE t AS (x int);
> >   CREATE TABLE parent OF t;
> >   CREATE TABLE child () INHERITS (parent);
> >   ALTER TYPE t ADD ATTRIBUTE y int CASCADE;
> >   -- ERROR:  column must be added to child tables too
> > We ought to just set INH_YES on the downstream command in ATTypedTableRecursion.
> > If we get to that point, the user did choose ALTER TYPE CASCADE; it seems fair
> > to assume he'd want inheritance recursion rather than a later error.
>
> Agreed.

Patch attached for that.  Apart from a comment, a test case and a doc update, it
turned out to be a one-liner.

Attachment

pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: pgbench \for or similar loop
Next
From: Robert Haas
Date:
Subject: Re: time-delayed standbys