On Thu, Feb 10, 2011 at 09:16:09PM +0200, Peter Eisentraut wrote:
> On tor, 2011-02-10 at 10:40 -0800, David Fetter wrote:
> > I think all such checks belong in .git/hooks/pre-commit, and need
> > to be as cross-platform as needed for committers. Would a
> > *n*x-based version do for a start?
>
> I think as a matter of principle, the only things that belongs into
> git hooks are things that relate to the repository itself, such as
> commit metadata (author checks, commit message spell checks, etc.).
> Anything that relates to the source belongs into the source.
So on that principle, should "make check" do these checks?
Just to put another viewpoint out there, the reason that such hooks
exist is precisely to enable people to do deeper checks than commit
metadata.
Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
