Error attribution in foreign scans - Mailing list pgsql-hackers

From Noah Misch
Subject Error attribution in foreign scans
Date
Msg-id 20110207121734.GB22669@tornado.gateway.2wire.net
Whole thread Raw
Responses Re: Error attribution in foreign scans  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
Suppose you create several file_fdw foreign tables, query them together, and
read(2) returns EIO for one of the files:

[local] postgres=# SELECT * FROM ft0, ft1, ft2;
ERROR:  could not read from COPY file: Input/output error

The message does not show which foreign table yielded the error.  We could evade
the problem in this case by adding a file name to the error message in the COPY
code, but that strategy doesn't translate to twitter_fdw, firebird_fdw, etc.  We
need a convention for presenting foreign errors that clearly attributes them to
the originating foreign table.  What should it be?

Perhaps something as simple as having the core foreign scan code push an error
context callback that does errcontext("scan of foreign table \"%s\"", tabname)?

Disclaimer: I have only skimmed SQL/MED patches other than copy_export.

Thanks,
nm


pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: SQL/MED - file_fdw
Next
From: Dimitri Fontaine
Date:
Subject: Re: Range Types