Noah Misch wrote:
> On Thu, Feb 03, 2011 at 05:53:28PM +0200, Peter Eisentraut wrote:
> > On tor, 2011-02-03 at 00:10 -0500, Noah Misch wrote:
> > > > This is good stuff. I'll send you a new patch in a day or three for
> > > > perhaps another round of performance tests. Some of the other
> > > issues
> > > > above can perhaps be postponed for follow-up patches.
> > >
> > > I agree -- if the performance-when-unused gets solid, none of my other
> > > comments ought to hold things up.
> >
> > Here is a new patch.
> >
> > The main change is in varstr_cmp(), avoiding the calls to
> > pg_newlocale_from_collation() when the default locale is used. This
> > accounts for the performance regression in my tests. It also addresses
> > some of your refactoring ideas.
>
> Looks good and tests well. I've attached the same benchmark script with updated
> timings, and I've marked the patch Ready for Committer.
Nice to see that performance hit is removed now!
-- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB
http://enterprisedb.com
+ It's impossible for everything to be true. +
