Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.
Date
Msg-id 2011.1291057769@sss.pgh.pa.us
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Mon, Nov 29, 2010 at 16:26, Robert Haas <robertmhaas@gmail.com> wrote:
>> That works for me. �But should we make a practice of writing the
>> ENTIRE SHA-ID rather than an abbreviated form, so that we could more
>> easily replace 'em later if need be?

> I think that's a good idea.

Just as a data point, there is already one 7-hex-digit collision in our
repository:

Branch: master Release: REL6_1 [aaeef4dae] 1997-04-09 08:29:35 +0000
Branch: master Release: REL6_1 [aaeef4d17] 1996-11-10 03:06:38 +0000

I think it's quite foolish to depend on abbreviated hashes to be unique
forever.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Remove outdated comments from the regression test files.
Next
From: Alvaro Herrera
Date:
Subject: Re: improving foreign key locks