Re: Moving pg_autovacuum from contrib to src/bin - Mailing list pgsql-patches

From Tom Lane
Subject Re: Moving pg_autovacuum from contrib to src/bin
Date
Msg-id 20107.1085843098@sss.pgh.pa.us
Whole thread Raw
In response to Re: Moving pg_autovacuum from contrib to src/bin  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
Peter Eisentraut <peter_e@gmx.net> writes:
> Matthew T. O'Connor wrote:
>> I did understand Tom, but based on the hacker discussion I think the
>> "postmaster integration" will consist of the postmaster launching and
>> killing the pg_autovacuum standalone executable as required.  In that
>> sense, I don't think it matters if pg_autovacuum is located in
>> src/bin or src/backend/postmaster.

> It is supposed to be linked into the postmaster and forked from there.

In the current state of pg_autovacuum it wouldn't matter a lot, but
I am assuming that we will soon migrate it to depend on being part of
the postmaster environment.  For instance, it ought to be configured
from GUC, which will mean it has to receive SIGHUP from the postmaster.
In an only slightly longer timeframe, it will probably want access to
shared memory so it can look at stats maintained in the FSM.  These
attributes would make it quite inappropriate for autovacuum to live in
src/bin.

BTW, Matthew, I am currently working on promoting the bgwriter into a
more full-fledged postmaster child.  If you can wait a day or so you
should have a decent model to work from.  I'll try to commit as soon
as a working skeleton is in place.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Matthew T. O'Connor"
Date:
Subject: Re: Moving pg_autovacuum from contrib to src/bin
Next
From: "Marc G. Fournier"
Date:
Subject: Re: Moving pg_autovacuum from contrib to src/bin