pgAdmin III commit: Make sure no query more than max size is stored... - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject pgAdmin III commit: Make sure no query more than max size is stored...
Date
Msg-id 201012260939.oBQ9dVQb077333@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
Make sure no query more than max size is stored...

in the historic file.

The issue was that, if pgAdmin was killed, the last query, whatever its size,
remained in the histoqueries file. I changed the behabiour so that it can't
happen anymore.

Old behaviour:

  When query is launched
    Save query
  When query is done
    If unsuccessul
      Delete query
    If successful
      If it's bigger than max size
        Delete query
      Else if already present
        Delete the old one

New behaviour

  When query is done
    If successful
      If it's less than max size
        Add query
      If already present
        Delete the old one

Per discussion with Dave Page and Michael Willekes.

Branch
------
REL-1_12_0_PATCHES

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7b48a5f03127457f9e2bb398d92aa0079d05573a

Modified Files
--------------
CHANGELOG                |    2 ++
pgadmin/frm/frmQuery.cpp |   38 +++++++++++++-------------------------
2 files changed, 15 insertions(+), 25 deletions(-)


pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Make sure no query more than max size is stored...
Next
From: "Hiroshi Saito"
Date:
Subject: Re: utffile symbol defined is strange.