Re: Patch to add a primary key using an existing index - Mailing list pgsql-hackers

From David Fetter
Subject Re: Patch to add a primary key using an existing index
Date
Msg-id 20101129065840.GC1942@fetter.org
Whole thread Raw
In response to Re: Patch to add a primary key using an existing index  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Sun, Nov 28, 2010 at 08:40:08PM -0500, Robert Haas wrote:
> On Sun, Nov 28, 2010 at 8:06 PM, Itagaki Takahiro
> <itagaki.takahiro@gmail.com> wrote:
> > On Fri, Nov 26, 2010 at 05:58, Steve Singer <ssinger@ca.afilias.info> wrote:
> >> The attached version of the patch gets your regression tests to
> >> pass.  I'm going to mark this as ready for a committer.
> >
> > I think we need more discussions about the syntax:  ALTER TABLE
> > table_name ADD PRIMARY KEY (...) WITH (INDEX='index_name')
> 
> Why not:
> 
> ALTER TABLE table_name ADD PRIMARY KEY (...) INDEX index_name;

+1 :)

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


pgsql-hackers by date:

Previous
From: Itagaki Takahiro
Date:
Subject: Re: pg_execute_from_file review
Next
From: Christoph Berg
Date:
Subject: [trivial patch] Ellipsis whitespace in SQL docs