Re: pgsql: Improve pg_ctl "cannot connect" warning, per suggestion from Mag - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Improve pg_ctl "cannot connect" warning, per suggestion from Mag
Date
Msg-id 201011261504.oAQF4NM06607@momjian.us
Whole thread Raw
In response to Re: pgsql: Improve pg_ctl "cannot connect" warning, per suggestion from Mag  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Improve pg_ctl "cannot connect" warning, per suggestion from Mag  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Tom Lane wrote:
> >> Why does this string contain doubled spaces?
>
> > You mean two spaces after a semicolon?   Isn't that normal?  This is the
> > string:
>
> Normal according to what?  In any case translatable error strings are
> not supposed to attempt to do formatting, and formatting is what that
> looks like to me.

Well, wikipedia says perhaps two spaces:

    http://en.wikipedia.org/wiki/Semicolon

    Semicolons are followed by a lower case letter, unless that letter is
    the first letter of a proper noun. They have no spaces before them, but
    one space after (possibly two when using monospaced fonts).

but answers.com says only one:

    http://wiki.answers.com/Q/How_many_spaces_after_a_colon_and_semicolon
    After a semicolon, there is never more than one space.

so I have changed it to once space, and also reworded it:

    warning:  could not connect; might be caused by invalid authentication or
    misconfiguration.

That wording seems to match other messages better, though I feel pg_ctl
seems to have sloppy output formatting in general.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

pgsql-committers by date:

Previous
From: Itagaki Takahiro
Date:
Subject: pgsql: Don't raise "identifier will be truncated" messages in dblink
Next
From: Bruce Momjian
Date:
Subject: pgsql: Improve pg_ctl "cannot connect" spacing, per Tom, and wording.