Re: [PATCH] V3: Idle in transaction cancellation - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] V3: Idle in transaction cancellation
Date
Msg-id 201011022236.19913.andres@anarazel.de
Whole thread Raw
In response to Re: [PATCH] V3: Idle in transaction cancellation  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
Responses Re: [PATCH] V3: Idle in transaction cancellation
Re: [PATCH] V3: Idle in transaction cancellation
List pgsql-hackers
On Tuesday 02 November 2010 18:33:15 Kevin Grittner wrote:
> Andres Freund <andres@anarazel.de> wrote:
> > * You wont see an error if the next command after the IDLE in
> > transaction is a COMMIT/ROLLBACK. I don*t see any sensible way
> > around that.
> Well, on a ROLLBACK I'm not sure it's a problem.  On a COMMIT,
> couldn't you call a function to check for it in CommitTransaction
> and PrepareTransaction?
Sure, throwing an error somewhere wouldnt be that hard. But at the moment a 
COMMIT is always successfull (and just reporting a ROLLBACK in a failed txn). 
Doesn't seem to be something to changed lightly.

Does anybody have any idea why COMMIT is allowed there? Seems pretty strange 
to me.

Andres


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Hash support for arrays
Next
From: Tom Lane
Date:
Subject: Re: Hash support for arrays