Re: pg_upgrade - Mailing list pgsql-general

From Bruce Momjian
Subject Re: pg_upgrade
Date
Msg-id 201009290241.o8T2fc721668@momjian.us
Whole thread Raw
In response to Re: pg_upgrade  (Brian Hirt <bhirt@me.com>)
List pgsql-general
Brian Hirt wrote:
> Bruce,
>
> The applied patch has the same behavior on i686 Ubuntu 10.04.   It
> looks like atol() is just a macro for strtol() in stdio.h.   I think
> you want strtoul() instead of strtol()

Yes, thanks.  I have now applied that fix in HEAD and 9.0.X.

> when i change str2uint() to use strtoul() pg_upgrade completes without
> a problem (I still haven't tested the upgrade database, but I expect
> that will be just fine).

Yep.

> I think it's pretty uncommon for the OID to be that big which is why
> nobody stumbled onto this.   This particular installation has pretty
> much been reloading development databases non stop for the last year.
> Also, people tend to initdb a lot when testing and doing development
> which will keep resetting the oid low.

Yes, seems > 2^31 oids are rarer than I thought.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

pgsql-general by date:

Previous
From: Darren Duncan
Date:
Subject: Re: How to handle results with column names clash
Next
From: Adam Wizon
Date:
Subject: Fwd: Restore problem from 8.4 backup to 9.0