Re: git cherry-pick timestamping issue - Mailing list pgsql-hackers

From Abhijit Menon-Sen
Subject Re: git cherry-pick timestamping issue
Date
Msg-id 20100923214631.GA5680@toroid.org
Whole thread Raw
In response to Re: git cherry-pick timestamping issue  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: git cherry-pick timestamping issue  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
At 2010-09-23 17:37:51 -0400, tgl@sss.pgh.pa.us wrote:
>
> Hm.  What git version are you using?

I'm using 1.7.3, yes. It has a bunch of timezone handling changes, but
I'm not sure if there's anything related to your problem. If you don't
have TZ set in your environment, I suppose the following patch *could*
be relevant, since you're in -0400 and I'm in +0530. I haven't tried
to verify this, but if cat-file -p on your backported commit shows an
absurdly high timezone value, then that's the problem.

Anyway, try 1.7.3 and see if it helps?

-- ams

commit 9ba0f0334dd505f78e0374bbe857c5e202f5a778
Author: Jeff King <peff@peff.net>
Date:   Sun Jul 4 07:00:17 2010 -0400
   parse_date: fix signedness in timezone calculation      When no timezone is specified, we deduce the offset by
subtractingthe result of mktime from our calculated   timestamp.      However, our timestamp is stored as an unsigned
integer,  meaning we perform the subtraction as unsigned. For a   negative offset, this means we wrap to a very high
number,  and our numeric timezone is in the millions of hours. You   can see this bug by doing:         $ TZ=EST \
 GIT_AUTHOR_DATE='2010-06-01 10:00' \        git commit -a -m foo      $ git cat-file -p HEAD | grep author      author
JeffKing <peff@peff.net> 1275404416 +119304128      Instead, we should perform this subtraction as a time_t, the   same
typethat mktime returns.      Signed-off-by: Jeff King <peff@peff.net>   Signed-off-by: Junio C Hamano
<gitster@pobox.com>


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: git cherry-pick timestamping issue
Next
From: Alvaro Herrera
Date:
Subject: Re: git cherry-pick timestamping issue