[REVIEW] Re: I: About "Our CLUSTER implementation is pessimal" patch - Mailing list pgsql-hackers

From Abhijit Menon-Sen
Subject [REVIEW] Re: I: About "Our CLUSTER implementation is pessimal" patch
Date
Msg-id 20100916074906.GA5038@toroid.org
Whole thread Raw
In response to Re: I: About "Our CLUSTER implementation is pessimal" patch  (Itagaki Takahiro <itagaki.takahiro@gmail.com>)
List pgsql-hackers
(Sorry for the broken threading. I didn't have a convenient copy of the
original message to reply to.)

I looked at the patch and it seems quite reasonable, but two hunks of
the changes to src/backend/commands/cluster.c don't apply cleanly. I'm
not sure what version the patch was generated against, but the code in
copy_heap_data() seems to have changed quite a bit. I don't think it
would be too much trouble to adapt the changes, though.

-- ams


pgsql-hackers by date:

Previous
From: Vaibhav Kaushal
Date:
Subject: Introducing Myself
Next
From: Markus Wanner
Date:
Subject: Re: bg worker: patch 1 of 6 - permanent process