pgAdmin III commit: Make the dlgSelectConnection combobox read/write - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject pgAdmin III commit: Make the dlgSelectConnection combobox read/write
Date
Msg-id 201008230835.o7N8ZfAk008209@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
Commit: http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=45c7b4de1badcbe050283b2c3a77f1db001d88d9

Log Message
-----------
Make the dlgSelectConnection combobox read/write

When a user launches the dlgSelectConnection dialog from the query tool, all
combobox are read-only, forcing the user to select one of the available items
on each combobox.

When a user launches pgAdmin with -q or -S command line options, he first gets
the dlgSelectConnection dialog. As no connection is already made, the only
thing the combox box will have depends on the previous quick connect action.
So, the combobox should be read/write, so that he can change the values.

It used to work in 1.10, but was broken since 1.12 because of one of my
patches.

Reported by Steffen Kuhn. Patch by him, reworked by me.

Branch
------
master

Modified Files
--------------
pgadmin/dlg/dlgSelectConnection.cpp       |   17 +++++++++++------
pgadmin/include/dlg/dlgSelectConnection.h |    2 +-
pgadmin/ui/dlgSelectConnection.xrc        |    9 ---------
3 files changed, 12 insertions(+), 16 deletions(-)


pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Make the dlgSelectConnection combobox read/write
Next
From: Guillaume Lelarge
Date:
Subject: Re: ReadOnly ComboBoxes in dlgSelectConnection.cpp