Re: Fw: patch for pg_ctl.c to add windows service start-type - Mailing list pgsql-hackers

From Quan Zongliang
Subject Re: Fw: patch for pg_ctl.c to add windows service start-type
Date
Msg-id 20100820070154.7096ab15.quanzongliang@gmail.com
Whole thread Raw
In response to Re: Fw: patch for pg_ctl.c to add windows service start-type  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Fw: patch for pg_ctl.c to add windows service start-type
List pgsql-hackers
Because Windows's CreateService has serial start-type:
SERVICE_AUTO_START
SERVICE_BOOT_START
SERVICE_DEMAND_START
SERVICE_DISABLED
SERVICE_SYSTEM_START

Although all of them are not useful for pg service.
I think it is better to use enum.

On Thu, 19 Aug 2010 16:48:53 -0400
Alvaro Herrera <alvherre@commandprompt.com> wrote:

> Excerpts from David Fetter's message of jue ago 19 16:40:18 -0400 2010:
> > On Thu, Aug 19, 2010 at 03:47:43PM -0400, Alvaro Herrera wrote:
> > > Excerpts from David Fetter's message of jue ago 19 11:48:53 -0400 2010:
> > > 
> > > > +    <varlistentry>
> > > > +     <term><option>-S <replaceable class="parameter"></replaceable></option></term>
> > > 
> > > You omitted the start-type inside the <replaceable> tag.  Also, the "a"
> > > and "d" values seem to be accepted but not documented.
> > 
> > D'oh!  Changed patch enclosed.  Now in context format :)
> 
> Thanks.
> 
> Another thing -- why is there an enum at all?  Seems it'd be
> simpler to assign the right value to the variable in the getopt() code
> to start with.
> 
> -- 
> Álvaro Herrera <alvherre@commandprompt.com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support


-- 
Quan Zongliang <quanzongliang@gmail.com>


pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Avoiding deadlocks ...
Next
From: Quan Zongliang
Date:
Subject: Re: Fw: patch for pg_ctl.c to add windows service start-type