pgsql: Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar" - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar"
Date
Msg-id 20100819181108.7B9D87541D7@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar" is simple.

It's not clear if this situation can occur in plpgsql other than via the
EXECUTE USING case Heikki illustrated, which I will shortly close off.
However, ignoring the intoClause if it's there is surely wrong, so let's
patch it for safety.

Backpatch to 8.3, which is as far back as this code has a PlannedStmt
to deal with.  There might be another way to make an equivalent test
before that, but since this is just preventing hypothetical bugs,
I'm not going to obsess about it.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/pl/plpgsql/src:
        pl_exec.c (r1.202.2.9 -> r1.202.2.10)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_exec.c?r1=1.202.2.9&r2=1.202.2.10)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar"
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar"