pgsql: Standardize get_whatever_oid functions for object types with - Mailing list pgsql-committers

From rhaas@postgresql.org (Robert Haas)
Subject pgsql: Standardize get_whatever_oid functions for object types with
Date
Msg-id 20100805144509.828227541D7@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Standardize get_whatever_oid functions for object types with
unqualified names.

- Add a missing_ok parameter to get_tablespace_oid.
- Avoid duplicating get_tablespace_od guts in objectNamesToOids.
- Add a missing_ok parameter to get_database_oid.
- Replace get_roleid and get_role_checked with get_role_oid.
- Add get_namespace_oid, get_language_oid, get_am_oid.
- Refactor existing code to use new interfaces.

Thanks to KaiGai Kohei for the review.

Modified Files:
--------------
    pgsql/src/backend/catalog:
        aclchk.c (r1.168 -> r1.169)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/aclchk.c?r1=1.168&r2=1.169)
        namespace.c (r1.125 -> r1.126)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/namespace.c?r1=1.125&r2=1.126)
    pgsql/src/backend/commands:
        alter.c (r1.37 -> r1.38)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/alter.c?r1=1.37&r2=1.38)
        comment.c (r1.115 -> r1.116)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/comment.c?r1=1.115&r2=1.116)
        dbcommands.c (r1.236 -> r1.237)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/dbcommands.c?r1=1.236&r2=1.237)
        foreigncmds.c (r1.11 -> r1.12)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/foreigncmds.c?r1=1.11&r2=1.12)
        indexcmds.c (r1.198 -> r1.199)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/indexcmds.c?r1=1.198&r2=1.199)
        opclasscmds.c (r1.69 -> r1.70)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/opclasscmds.c?r1=1.69&r2=1.70)
        proclang.c (r1.91 -> r1.92)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/proclang.c?r1=1.91&r2=1.92)
        schemacmds.c (r1.57 -> r1.58)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/schemacmds.c?r1=1.57&r2=1.58)
        tablecmds.c (r1.338 -> r1.339)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c?r1=1.338&r2=1.339)
        tablespace.c (r1.78 -> r1.79)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablespace.c?r1=1.78&r2=1.79)
        user.c (r1.193 -> r1.194)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/user.c?r1=1.193&r2=1.194)
    pgsql/src/backend/executor:
        execMain.c (r1.353 -> r1.354)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execMain.c?r1=1.353&r2=1.354)
    pgsql/src/backend/libpq:
        hba.c (r1.209 -> r1.210)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/libpq/hba.c?r1=1.209&r2=1.210)
    pgsql/src/backend/utils/adt:
        acl.c (r1.157 -> r1.158)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/acl.c?r1=1.157&r2=1.158)
        dbsize.c (r1.31 -> r1.32)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/dbsize.c?r1=1.31&r2=1.32)
    pgsql/src/backend/utils/cache:
        lsyscache.c (r1.171 -> r1.172)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/cache/lsyscache.c?r1=1.171&r2=1.172)
    pgsql/src/include/catalog:
        namespace.h (r1.62 -> r1.63)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/namespace.h?r1=1.62&r2=1.63)
    pgsql/src/include/commands:
        dbcommands.h (r1.50 -> r1.51)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/commands/dbcommands.h?r1=1.50&r2=1.51)
        defrem.h (r1.102 -> r1.103)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/commands/defrem.h?r1=1.102&r2=1.103)
        proclang.h (r1.15 -> r1.16)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/commands/proclang.h?r1=1.15&r2=1.16)
        tablespace.h (r1.23 -> r1.24)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/commands/tablespace.h?r1=1.23&r2=1.24)
    pgsql/src/include/utils:
        acl.h (r1.113 -> r1.114)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/acl.h?r1=1.113&r2=1.114)
        lsyscache.h (r1.133 -> r1.134)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/lsyscache.h?r1=1.133&r2=1.134)

pgsql-committers by date:

Previous
From: petere@postgresql.org (Peter Eisentraut)
Date:
Subject: pgsql: Add xmlexists function by Mike Fowler, reviewed by Peter
Next
From: rhaas@postgresql.org (Robert Haas)
Date:
Subject: pgsql: Standardize get_whatever_oid functions for other object types.