pgsql: Fix "cannot handle unplanned sub-select" error that can occur - Mailing list pgsql-committers

Log Message:
-----------
Fix "cannot handle unplanned sub-select" error that can occur when a
sub-select contains a join alias reference that expands into an expression
containing another sub-select.  Per yesterday's report from Merlin Moncure
and subsequent off-list investigation.

Back-patch to 7.4.  Older versions didn't attempt to flatten sub-selects in
ways that would trigger this problem.

Tags:
----
REL7_4_STABLE

Modified Files:
--------------
    pgsql/src/backend/optimizer/util:
        var.c (r1.54 -> r1.54.4.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/var.c?r1=1.54&r2=1.54.4.1)
    pgsql/src/test/regress/expected:
        subselect.out (r1.8 -> r1.8.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/subselect.out?r1=1.8&r2=1.8.2.1)
    pgsql/src/test/regress/sql:
        subselect.sql (r1.5 -> r1.5.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/subselect.sql?r1=1.5&r2=1.5.2.1)