Re: 9.0beta2 - server crash when using HS + SR - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: 9.0beta2 - server crash when using HS + SR
Date
Msg-id 201007020244.o622imV20225@momjian.us
Whole thread Raw
In response to Re: 9.0beta2 - server crash when using HS + SR  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > The attached patch shows the hint only during recovery.
> > 
> > BTW, it would be easier and more consistent with the rest of the code to
> > look at InRecovery, instead of messing around with the function
> > signature.  And the usual way to emit a hint conditionally is
> > 
> >     (InRecovery ? errhint(...) : 0)
> > 
> > rather than duplicate a lot of surrounding code.
> 
> Thanks for the "hints".   I was thinking there was a way to use ? : for
> the hint, but couldn't find an example.  I see examples now.  Updated
> patch attached.

Applied.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + None of us is going to be here forever. +


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: bitmap indexes - performance
Next
From: Bruce Momjian
Date:
Subject: Re: failover vs. read only queries