Re: fillfactor gets set to zero for toast tables - Mailing list pgsql-hackers

From Takahiro Itagaki
Subject Re: fillfactor gets set to zero for toast tables
Date
Msg-id 20100604130800.9993.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: fillfactor gets set to zero for toast tables  (Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>)
List pgsql-hackers
Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> wrote:

> Could you explain why default_only entries idea is
> better than adjusting those fields in the toast-specific codes?
> It's my understanding that reloption-framework is just a tool to fill
> reloption parameters, and it's not responsible for unused fields.

Here is my proposal to fix the issue. I didn't introduce default_only
field but simply adjust parameters for TOAST reloptions.


BTW, not only heap and toast relations but also btree, hash, and gist
indexes use StdRdOptions. However, they actually don't support autovacuum
options. So, StdRdOptions is a bloated all-in-one descriptor now.
Instead, they should use fillfactor-only reloptions that is defined
separately from options for heap.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center


Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: functional call named notation clashes with SQL feature
Next
From: KaiGai Kohei
Date:
Subject: Re: [PATCH] Fix leaky VIEWs for RLS