Postgres Pro
Downloads
Home   >   mailing lists

pgsql: Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV
Date
Msg-id 20100309223459.022B57541D0@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Tree view 
Log Message:
-----------
Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV in plperl.
The latter is considered unwarranted chumminess with the implementation,
and can lead to crashes with recent Perl versions.

Report and fix by Tim Bunce.  Back-patch to all versions containing the
questionable coding pattern.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/pl/plperl:
        plperl.c (r1.136.2.7 -> r1.136.2.8)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c?r1=1.136.2.7&r2=1.136.2.8)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV