Postgres Pro
Downloads
Home   >   mailing lists

pgsql: Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV
Date
Msg-id 20100309223439.10E4F7541D0@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Tree view 
Log Message:
-----------
Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV in plperl.
The latter is considered unwarranted chumminess with the implementation,
and can lead to crashes with recent Perl versions.

Report and fix by Tim Bunce.  Back-patch to all versions containing the
questionable coding pattern.

Modified Files:
--------------
    pgsql/src/pl/plperl:
        plperl.c (r1.170 -> r1.171)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c?r1=1.170&r2=1.171)

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Update time zone data files to tzdata release 2010d: DST law
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Use SvROK(sv) rather than directly checking SvTYPE(sv) == SVt_RV