Re: A thought: should we run pgindent now? - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: A thought: should we run pgindent now?
Date
Msg-id 20100218151345.GC6317@alvh.no-ip.org
Whole thread Raw
In response to Re: A thought: should we run pgindent now?  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan wrote:
> 
> 
> Alvaro Herrera wrote:
> >Magnus Hagander wrote:
> >
> >>Doesn't that require that all pgindent runs produce the same output?
> >>Which they generally don't due to different sets of typedefs and
> >>stuff? It's a solvable problem of course, but not quite as simple as
> >>you make it sound :-)
> >
> >The typedef file emitted by the buildfarm is supposed to be rather
> >static, no?
> 
> Umm, static in what sense? Clearly if we add things to the code that
> can involve extra typedefs being found. The buildfarm's list is the
> union of all the typedefs found by the contributing members at the
> time they do their runs.

Yeah, but most typedefs are already there; I mean we're not likely to
change even 5% of the current list.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: A thought: should we run pgindent now?
Next
From: Dimitri Fontaine
Date:
Subject: Re: Avoiding bad prepared-statement plans.