Re: log_error_verbosity function display - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: log_error_verbosity function display
Date
Msg-id 201002112247.o1BMlZ216064@momjian.us
Whole thread Raw
In response to Re: log_error_verbosity function display  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: log_error_verbosity function display
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Jaime Casanova wrote:
> >> i like this with or without the (), but maybe we are breaking client
> >> apps if change that
> 
> > Ah, so you like FUNCTION.
> 
> You can NOT change the line tag without almost certainly breaking
> log-reading tools like pgfouine.  Even changing the content of the line
> risks that, and for no visible gain.
> 
> This seems like the worst form of bike-shedding to me.  This log entry
> has been formatted this way since 7.4, and nobody has ever complained
> about it, until you suddenly decided it was a problem.  Leave it be.

I propose to add '()' because it is confusing without it.  I don't think
many people are using the feature or we would have received suggestions
for improvmement.  As you can see, once I posted about it, there were a
number of people who wanted improvements.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Koichi Suzuki
Date:
Subject: Re: [GENERAL] Bug on pg_lesslog
Next
From: Koichi Suzuki
Date:
Subject: Re: [GENERAL] Bug on pg_lesslog