Re: [PATCH] Provide rowcount for utility SELECTs - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Provide rowcount for utility SELECTs
Date
Msg-id 20100211193853.GG3145@alvh.no-ip.org
Whole thread Raw
In response to Re: [PATCH] Provide rowcount for utility SELECTs  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [PATCH] Provide rowcount for utility SELECTs
List pgsql-hackers
Robert Haas escribió:

> I was all prepared to admit that I hadn't actually looked at the patch
> carefully enough, but I just looked at (and CVS HEAD) again and what
> you've written here doesn't appear to describe what I'm seeing in the
> code:
> 
>                 if ((portal->strategy != PORTAL_ONE_SELECT) && (!portal->holdStore))
>                     FillPortalStore(portal, isTopLevel);
> 
> So one of us is confused... it may well be me.

Ah, it seems I misread it ... but then I don't quite see the point in
that change.

Well, not doing a full review anyway, so never mind me.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Remove old-style VACUUM FULL (which was known for a little while
Next
From: Bruce Momjian
Date:
Subject: Re: log_error_verbosity function display