Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Provide rowcount for utility SELECTs - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Provide rowcount for utility SELECTs
Date
Msg-id 20100211190408.GD3145@alvh.no-ip.org
Whole thread Raw
In response to Re: [PATCH] Provide rowcount for utility SELECTs  (Boszormenyi Zoltan <zb@cybertec.at>)
Responses Re: [PATCH] Provide rowcount for utility SELECTs
Re: [PATCH] Provide rowcount for utility SELECTs
List pgsql-hackers
Tree view 
Boszormenyi Zoltan escribió:
> Robert Haas írta:
> > ...
> > OK, please change it.
> >   
> 
> New patch is attached with the discussed changes.

This looks all wrong.  PORTAL_ONE_SELECT is now being passed through
FillPortalStore, which runs it to completion, whereas it was previously
passed via PortalRunSelect first, which has different semantics
regarding the "count" arg.

Also, even if that weren't wrong, FillPortalStore states at its header
comment that it is only used for the other two cases (ONE_RETURNING and
UTIL_SELECT), but now is being used for ONE_SELECT as well.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [PATCH] Provide rowcount for utility SELECTs
Next
From: Simon Riggs
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Remove old-style VACUUM FULL (which was known for a little while