Re: pgsql: Add C comments that HEAP_MOVED_* define usage is only for pre-9.0 - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Add C comments that HEAP_MOVED_* define usage is only for pre-9.0
Date
Msg-id 201002081714.o18HE9r04830@momjian.us
Whole thread Raw
List pgsql-committers
bruce wrote:
> Tom Lane wrote:
> > momjian@postgresql.org (Bruce Momjian) writes:
> > > Log Message:
> > > -----------
> > > Add C comments that HEAP_MOVED_* define usage is only for pre-9.0 binary
> > > upgrades.
> >
> > This seems fairly redundant with the comments that were already there.
>
> The comment was at the top of SetHintBits(), which I didn't think would
> be seen near the many other references to HEAP_MOVED_* father down
> in the file.

The only other thing we could do is to mention the HEAP_MOVED_* only at
the top of the file, but I have tried to label binary upgrade code
clearly so we know why it is there and when it can be removed.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix serious performance bug in new implementation of VACUUM FULL:
Next
From: heikki@postgresql.org (Heikki Linnakangas)
Date:
Subject: pgsql: Remove obsolete comment about 'fsm' argument, which isn't an