handling contrib directories as modules not shared libraries - Mailing list pgsql-hackers

From brook@biology.nmsu.edu (Brook Milligan)
Subject handling contrib directories as modules not shared libraries
Date
Msg-id 20100124010051.5A9331177E2D@viola.localdomain
Whole thread Raw
Responses Re: handling contrib directories as modules not shared libraries
Re: handling contrib directories as modules not shared libraries
List pgsql-hackers
It seems that src/Makefile.shlib has special cases for several
directories that build loadable modules rather than shared libraries.
The contrib/adminpack is one of the special cases, but none of the
other contrib directories are.  As a result, they get built as shared
libraries (i.e., as libXXX.so rather than XXX.so) and the
corresponding *.sql.in files that load them refer to the wrong file
and therefore fail.  The following patch (against the 8.3 release)
fixes this by expanding the set of special cases to include all the
contrib directories, not just contrib/adminpack.  I only have tested
this with the uuid module, but it appears that all of them have the
same organization.

--- src/Makefile.shlib.orig
+++ src/Makefile.shlib
@@ -21,7 +21,7 @@ifneq (,$(findstring src/pl/,$(subdir)))shmodule    = yeselse
-ifneq (,$(findstring contrib/adminpack,$(subdir)))
+ifneq (,$(findstring contrib/,$(subdir)))shmodule    = yeselseshmodule    = no

Cheers,
Brook


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: commit fests
Next
From: KaiGai Kohei
Date:
Subject: Re: restructuring "alter table" privilege checks (was: remove redundant ownership checks)