Re: per-user pg_service.conf - Mailing list pgsql-hackers

From Christoph Berg
Subject Re: per-user pg_service.conf
Date
Msg-id 20100115123707.GC8810@df7cb.de
Whole thread Raw
In response to Re: per-user pg_service.conf  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: per-user pg_service.conf
List pgsql-hackers
> > I was surprised/annoyed to find out that there is no way to have
> > per-user pg_service.conf, something like ~/.pg_service.conf (well,
> > except by export PGSYSCONFDIR).  That would be easy to add.
> > Comments?
>
> Here's a patch.  Perhaps those who had said they would like that can
> validate the behavior.

Hi,

I just tried the ~/.pg_service.conf patch and it does everything I'd
expect from it. It even improves the documentation to include a
services file example for which I had been looking several times
earlier.

There's not much I have to add, maybe the documentation could add a
pointer to what keywords are recognized:

| The file uses an "INI file" format where the section name is the
| service name and the parameters are connection parameters.

... (see Section 30.1 for a list).

Independently for what this patch changes, error reporting could be
more detailed, currently "syntax error in service file \"%s\", line
%d" is reported for "no = in line" and "keyword X is unknown". The
latter case deserves a different message, maybe like "keyword \"%s\"
is invalid in service file \"%s\", line %d".

Even without the proposed changed, I'd very much appreciate the patch
getting included.

Christoph
--
cb@df7cb.de | http://www.df7cb.de/

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Streaming replication, loose ends
Next
From: Michael Meskes
Date:
Subject: Re: ECPG DESCRIBE [OUTPUT] support