pgsql: Fix similar_escape() to convert parentheses to non-capturing - Mailing list pgsql-committers

Log Message:
-----------
Fix similar_escape() to convert parentheses to non-capturing style.
This is needed to avoid unwanted interference with SUBSTRING behavior,
as per bug #5257 from Roman Kononov.  Also, add some basic intelligence
about character classes (bracket expressions) since we now have several
behaviors that aren't appropriate inside a character class.

As with the previous patch in this area, I'm reluctant to back-patch
since it might affect applications that are relying on the prior
behavior.

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        regexp.c (r1.85 -> r1.86)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/regexp.c?r1=1.85&r2=1.86)