Re: [HACKERS] pgbench randomness initialization - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] pgbench randomness initialization
Date
Msg-id 20094.1520020246@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] pgbench randomness initialization  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> Hm ... so I tried to replicate this problem, and failed to: the log files
>> get made under the VPATH build directory, as desired, even without this
>> patch.  Am I doing something wrong, or is this platform-dependent somehow?

> As I recall, it indeed works if the source directories are rw, but fails 
> if they are ro because then the local mkdir fails. So you would have to do 
> a vpath build with sources that are ro to get the issue the patch is 
> fixing.

Ah, right you are.  Apparently, if the source is rw, the temporary files
in question are made there but immediately deleted, so the bug isn't
obvious.

Fix verified and pushed.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: 2018-03 Commitfest Summary (Andres #1)
Next
From: Andres Freund
Date:
Subject: Re: 2018-03 Commitfest Summary (Andres #1)