pgsql: Set errno to zero before invoking SSL_read or SSL_write. - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Set errno to zero before invoking SSL_read or SSL_write.
Date
Msg-id 20091230034601.C1D5A753FBC@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Set errno to zero before invoking SSL_read or SSL_write.  It appears that
at least in some Windows versions, these functions are capable of returning
a failure indication without setting errno.  That puts us into an infinite
loop if the previous value happened to be EINTR.  Per report from Brendan
Hill.

Back-patch to 8.2.  We could take it further back, but since this is only
known to be an issue on Windows and we don't support Windows before 8.2,
it does not seem worth the trouble.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/backend/libpq:
        be-secure.c (r1.83.2.2 -> r1.83.2.3)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/libpq/be-secure.c?r1=1.83.2.2&r2=1.83.2.3)
    pgsql/src/interfaces/libpq:
        fe-secure.c (r1.102.2.2 -> r1.102.2.3)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-secure.c?r1=1.102.2.2&r2=1.102.2.3)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Set errno to zero before invoking SSL_read or SSL_write.
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Set errno to zero before invoking SSL_read or SSL_write.