Postgres Pro
Downloads
Home   >   mailing lists

Re: pgbench: new feature allowing to launch shell commands - Mailing list pgsql-hackers

From Takahiro Itagaki
Subject Re: pgbench: new feature allowing to launch shell commands
Date
Msg-id 20091209151232.36C3.52131E4D@oss.ntt.co.jp
Whole thread Raw
In response to Re: pgbench: new feature allowing to launch shell commands  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: pgbench: new feature allowing to launch shell commands
List pgsql-hackers
Tree view 
Michael Paquier <michael.paquier@gmail.com> wrote:

> Please find attached the latest version of the patch,
> with the threading bug corrected and the documentation updated as well.

Why do you use BUFFER_SIZE-1 for snprintf?  snprintf(commandShell, SHELL_COMMAND_SIZE-1, ...)
Trailing nulls are also included in the length, so  snprintf(commandShell, SHELL_COMMAND_SIZE, ...)
would be ok. (removed -1)

Other parts look fine, except an empty tag <replaceable></> in the
documentation. Is it a typo?

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

pgsql-hackers by date:

Previous
From: Takahiro Itagaki
Date:
Subject: Re: EXPLAIN BUFFERS
Next
From: Magnus Hagander
Date:
Subject: Re: Adding support for SE-Linux security