Re: Aggregate ORDER BY patch - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Aggregate ORDER BY patch
Date
Msg-id 20091203195233.GN5059@alvh.no-ip.org
Whole thread Raw
In response to Re: Aggregate ORDER BY patch  (Hitoshi Harada <umi.tanuki@gmail.com>)
List pgsql-hackers
Hitoshi Harada escribió:

> I found only trivial favors such like that a blank line is added
> around line 595 in the patch, and "proj" in peraggstate sounds a
> little weird to me because of surrounding "evaldesc" and "evalslot"
> ("evalproj" seems better to me). Also catversion update doesn't mean
> anything for this feature. But these are not what prevent it from
> review by a committer. So, although I'm going to look more on this
> patch, I mark this item as "Ready for Committer" for now.

AFAICS the catversion bump is needed because of the change in a parser
node.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Largeobject Access Controls (r2432)
Next
From: "Jonah H. Harris"
Date:
Subject: Re: Block-level CRC checks