pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff
Date
Msg-id 20091122175423.E852A753FB7@cvs.postgresql.org
Whole thread Raw
Responses Re: pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff
List pgsql-committers
Log Message:
-----------
Remove -w (--ignore-all-space) option from pg_regress's diff calls.

We have used -w for a long time as a means of reducing the reported diff
volume when one element of a result table isn't of the expected width.
However, most of the time the results just pass anyway, so this isn't as
important as it once was.  Meanwhile, the risk of missing potentially
significant deviations has gone up, particularly with psql's ability to
report error cursor positions.  So, let's switch over to space-sensitive
comparisons.  Per my proposal of yesterday.

(All the expected files that I can test here seem to be ready for this
already, but we'll see what the buildfarm thinks about others.)

Modified Files:
--------------
    pgsql/src/test/regress:
        pg_regress.c (r1.65 -> r1.66)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/pg_regress.c?r1=1.65&r2=1.66)

pgsql-committers by date:

Previous
From: heikki@postgresql.org (Heikki Linnakangas)
Date:
Subject: pgsql: Remove superfluous curly brace, fixing compilation with
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Adjust expected-results spacing per buildfarm results.