pgsql: Fix AfterTriggerSaveEvent to use a test and elog, not just - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Fix AfterTriggerSaveEvent to use a test and elog, not just
Date
Msg-id 20091027201440.EDAC1753FB7@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Fix AfterTriggerSaveEvent to use a test and elog, not just Assert, to check
that it's called within an AfterTriggerBeginQuery/AfterTriggerEndQuery pair.
The RI cascade triggers suppress that overhead on the assumption that they
are always run non-deferred, so it's possible to violate the condition if
someone mistakenly changes pg_trigger to mark such a trigger deferred.
We don't really care about supporting that, but throwing an error instead
of crashing seems desirable.  Per report from Marcelo Costa.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/backend/commands:
        trigger.c (r1.227.2.2 -> r1.227.2.3)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/trigger.c?r1=1.227.2.2&r2=1.227.2.3)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix AfterTriggerSaveEvent to use a test and elog, not just
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix AfterTriggerSaveEvent to use a test and elog, not just