Review of "SQLDA support for ECPG" - Mailing list pgsql-hackers

From Noah Misch
Subject Review of "SQLDA support for ECPG"
Date
Msg-id 20091004060022.GA31633@tornado.leadboat.com
Whole thread Raw
Responses Re: Review of "SQLDA support for ECPG"
List pgsql-hackers
I took a look at 2-pg85-sqlda-10-ctxdiff.patch.  Starting from CVS HEAD of
roughly 2009-10-03 05:00 UTC, prerequisite patches 1a-1h applied cleanly.
2-pg85-sqlda hit a trivial whitespace reject in ecpg.trailer along with a more
substantive reject at ecpg.addons:407 (FetchStmtMOVEfetch_args).  Fixing it up
by hand leads to my first question - why did the transition from `opt_ecpg_into'
to `opt_ecpg_fetch_into' affect FETCH FORWARD and not FETCH BACKWARD?

The main test suite acquired no regressions, but I get failures in two tests of
the ecpg test suite (make -C src/interfaces/ecpg/test check).  I attach
regression.{out,diff} and postmaster.log from the test run.  The abort in
sqlda.pgc looks like the interesting failure, but I exhausted time with which to
dig into it further.  preproc/cursor.pgc creates (and ideally drops) the same
table `t1' as compat_informix/{sqlda,cursor}.pgc, so a crash in either of the
others makes it fail too.  Could they all use temp tables, use different table
names, or `DROP TABLE IF EXISTS t1' first?

Do those logs suggest the cause of the sqlda.pgc failure?  If not, I will look
into it further.  Otherwise, I'm happy to review a future iteration of the
patch.

As a side note, with patch 1* but not patch 2, test_informix entered an infinite
loop with this error:
ERROR:  syntax error at or near "c" at character 15
STATEMENT:  fetch forward c

Thank you,
nm

Attachment

pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: CommitFest 2009-09, two weeks on
Next
From: Peter Eisentraut
Date:
Subject: Re: Getting the red out (of the buildfarm)