pgsql: Simplify the bootstrap (BKI) code by getting rid of a useless - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Simplify the bootstrap (BKI) code by getting rid of a useless
Date
Msg-id 20090927013211.760F1753FB7@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Simplify the bootstrap (BKI) code by getting rid of a useless table of all
the strings seen during the bootstrap run.  There might have been some
actual point to doing that, many years ago, but as far as I can see the only
value now is to conserve a bit of memory.  Even if we cared about wasting
a megabyte or so during the initdb run, it'd be far more effective to
arrange to release memory at the end of each BKI command, instead of
intentionally hanging onto strings that might never be used again.
Not maintaining the table probably makes it faster too; but the main point
of this patch is to get rid of a couple hundred lines of unnecessary and
rather crufty code.

Modified Files:
--------------
    pgsql/src/backend/bootstrap:
        bootparse.y (r1.98 -> r1.99)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/bootparse.y?r1=1.98&r2=1.99)
        bootscanner.l (r1.49 -> r1.50)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/bootscanner.l?r1=1.49&r2=1.50)
        bootstrap.c (r1.252 -> r1.253)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/bootstrap.c?r1=1.252&r2=1.253)
    pgsql/src/include/bootstrap:
        bootstrap.h (r1.52 -> r1.53)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/bootstrap/bootstrap.h?r1=1.52&r2=1.53)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Hmm, seems a lot of the buildfarm is running versions of awk that
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Ooops, fix to Genbki.pm for ROWTYPE_OID wasn't quite right.