Postgres Pro
Downloads
Home   >   mailing lists

pgsql: Fix pg_ctl's readfile() to not go into infinite loop on an empty - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Fix pg_ctl's readfile() to not go into infinite loop on an empty
Date
Msg-id 20090902024107.3CD3475331E@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Tree view 
Log Message:
-----------
Fix pg_ctl's readfile() to not go into infinite loop on an empty file
(could happen if either postgresql.conf or postmaster.opts is empty).
It's been broken since the C version was written for 8.0, so patch
all the way back.

initdb's copy of the function is broken in the same way, but it's
less important there since the input files should never be empty.
Patch that in HEAD only, and also fix some cosmetic differences that
crept into that copy of the function.

Per report from Corry Haines and Jeff Davis.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/bin/pg_ctl:
        pg_ctl.c (r1.92.2.6 -> r1.92.2.7)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_ctl/pg_ctl.c?r1=1.92.2.6&r2=1.92.2.7)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix pg_ctl's readfile() to not go into infinite loop on an empty
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix pg_ctl's readfile() to not go into infinite loop on an empty