Re: [BUGS] fillfactor hides autovacuum parameters in 8.4.0 - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [BUGS] fillfactor hides autovacuum parameters in 8.4.0
Date
Msg-id 20090827154336.GG11213@alvh.no-ip.org
Whole thread Raw
In response to Re: [BUGS] fillfactor hides autovacuum parameters in 8.4.0  (Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
Responses Re: [BUGS] fillfactor hides autovacuum parameters in 8.4.0  (Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
List pgsql-hackers
Itagaki Takahiro wrote:
> 
> Here is a patch to fix a bug in handling default values in reloptions.
> This fix should be applied to HEAD and 8.4.0.
> 
> I used 'magic number -1' to propagate "not-specified" information to
> autovacuum process. It might look strange because the default value is
> out of range of the reloption, but I think it has less impact to the
> codes comapred with other solutions (dynamic default values etc.).

I realized that any other solution here is going to be more complex and
thus less appropriate for backpatch.  I still don't like this very much
because it doesn't seem to offer enough flexibility to user-specified
reloptions; but any patch we come up with here is going to be applicable
to CVS HEAD.

So I'm going to apply your patch to both 8.4 and HEAD; we can always
improve it later, I guess.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: 8.5 release timetable, again
Next
From: Alvaro Herrera
Date:
Subject: Re: BUG #4996: postgres.exe memory consumption keeps going up